Diamond75/Panda3DS
1
0
Fork 0
mirror of https://github.com/wheremyfoodat/Panda3DS.git synced 2025-04-06 06:05:40 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

GPU registers: Fix writes to some registers ignoring the mask (#725)

Browse source 
Co-authored-by: henry <23128103+atem2069@users.noreply.github.com>
This commit is contained in:
wheremyfoodat 2025-02-21 20:22:51 +02:00 • committed by GitHub
parent 2da79414d6
commit 0a0ea75013
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/core/PICA/regs.cpp
View file

@ -284,7 +284,7 @@ void GPU::writeInternalReg(u32 index, u32 value, u32 mask) {
break; break;
case VertexShaderOpDescriptorIndex: { case VertexShaderOpDescriptorIndex: {
shaderUnit.vs.setOpDescriptorIndex(value); shaderUnit.vs.setOpDescriptorIndex(newValue);
break; break;
} }
@ -301,7 +301,7 @@ void GPU::writeInternalReg(u32 index, u32 value, u32 mask) {
} }
case VertexBoolUniform: { case VertexBoolUniform: {
shaderUnit.vs.uploadBoolUniform(value & 0xffff); shaderUnit.vs.uploadBoolUniform(newValue & 0xffff);
break; break;
} }
@ -309,7 +309,7 @@ void GPU::writeInternalReg(u32 index, u32 value, u32 mask) {
case VertexIntUniform1: case VertexIntUniform1:
case VertexIntUniform2: case VertexIntUniform2:
case VertexIntUniform3: { case VertexIntUniform3: {
shaderUnit.vs.uploadIntUniform(index - VertexIntUniform0, value); shaderUnit.vs.uploadIntUniform(index - VertexIntUniform0, newValue);
break; break;
} }
@ -326,7 +326,7 @@ void GPU::writeInternalReg(u32 index, u32 value, u32 mask) {
} }
case VertexShaderEntrypoint: { case VertexShaderEntrypoint: {
shaderUnit.vs.entrypoint = value & 0xffff; shaderUnit.vs.entrypoint = newValue & 0xffff;
break; break;
} }
@ -336,13 +336,13 @@ void GPU::writeInternalReg(u32 index, u32 value, u32 mask) {
break; break;
*/ */
case VertexShaderTransferIndex: shaderUnit.vs.setBufferIndex(value); break; case VertexShaderTransferIndex: shaderUnit.vs.setBufferIndex(newValue); break;
// Command lists can write to the command processor registers and change the command list stream // Command lists can write to the command processor registers and change the command list stream
// Several games are known to do this, including New Super Mario Bros 2 and Super Mario 3D Land // Several games are known to do this, including New Super Mario Bros 2 and Super Mario 3D Land
case CmdBufTrigger0: case CmdBufTrigger0:
case CmdBufTrigger1: { case CmdBufTrigger1: {
if (value != 0) { // A non-zero value triggers command list processing if (newValue != 0) { // A non-zero value triggers command list processing
int bufferIndex = index - CmdBufTrigger0; // Index of the command buffer to execute (0 or 1) int bufferIndex = index - CmdBufTrigger0; // Index of the command buffer to execute (0 or 1)
u32 addr = (regs[CmdBufAddr0 + bufferIndex] & 0xfffffff) << 3; u32 addr = (regs[CmdBufAddr0 + bufferIndex] & 0xfffffff) << 3;
u32 size = (regs[CmdBufSize0 + bufferIndex] & 0xfffff) << 3; u32 size = (regs[CmdBufSize0 + bufferIndex] & 0xfffff) << 3;