Diamond75/Panda3DS
1
0
Fork 0
mirror of https://github.com/wheremyfoodat/Panda3DS.git synced 2025-04-18 03:31:31 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

Consider surface-support in device partitions

Browse source 
Use a stable_partitioning of the list of devices the driver gave us with
the addition of checking of the physical device supports the
display-surface that SDL gave us as well.
This commit is contained in:
Wunkolo 2023-07-18 23:32:21 -07:00
parent 0ada1f4e38
commit 165134ca40
1 changed files with 32 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

48
src/core/renderer_vk/renderer_vk.cpp
View file

@ -84,21 +84,43 @@ void RendererVK::initGraphicsContext(SDL_Window* window) {
} }
} }
// Pick physical device // Create surface
if (auto EnumerateResult = instance->enumeratePhysicalDevices(); EnumerateResult.result == vk::Result::eSuccess) { if (VkSurfaceKHR newSurface; SDL_Vulkan_CreateSurface(window, instance.get(), &newSurface)) {
std::vector<vk::PhysicalDevice> PhysicalDevices = std::move(EnumerateResult.value); surface.reset(newSurface);
} else {
Helpers::warn("Error creating Vulkan surface");
}
// Prefer Discrete GPUs // Pick physical device
const auto IsDiscrete = [](const vk::PhysicalDevice& PhysicalDevice) -> bool { if (auto enumerateResult = instance->enumeratePhysicalDevices(); enumerateResult.result == vk::Result::eSuccess) {
return PhysicalDevice.getProperties().deviceType == vk::PhysicalDeviceType::eDiscreteGpu; std::vector<vk::PhysicalDevice> physicalDevices = std::move(enumerateResult.value);
std::vector<vk::PhysicalDevice>::iterator partitionEnd = physicalDevices.end();
// Prefer GPUs that can access the surface
const auto surfaceSupport = [this](const vk::PhysicalDevice& physicalDevice) -> bool {
const usize queueCount = physicalDevice.getQueueFamilyProperties().size();
for (usize queueIndex = 0; queueIndex < queueCount; ++queueIndex) {
if (auto supportResult = physicalDevice.getSurfaceSupportKHR(queueIndex, surface.get());
supportResult.result == vk::Result::eSuccess) {
return supportResult.value;
}
}
return false;
}; };
std::partition(PhysicalDevices.begin(), PhysicalDevices.end(), IsDiscrete); partitionEnd = std::stable_partition(physicalDevices.begin(), partitionEnd, surfaceSupport);
// Pick the "best" out of all of the previous criteria // Prefer Discrete GPUs
physicalDevice = PhysicalDevices.front(); const auto isDiscrete = [](const vk::PhysicalDevice& physicalDevice) -> bool {
return physicalDevice.getProperties().deviceType == vk::PhysicalDeviceType::eDiscreteGpu;
};
partitionEnd = std::stable_partition(physicalDevices.begin(), partitionEnd, isDiscrete);
// Pick the "best" out of all of the previous criteria, preserving the order that the
// driver gave us the devices in(ex: optimus configuration)
physicalDevice = physicalDevices.front();
} else { } else {
Helpers::panic("Error enumerating physical devices: %s\n", vk::to_string(EnumerateResult.result).c_str()); Helpers::panic("Error enumerating physical devices: %s\n", vk::to_string(enumerateResult.result).c_str());
} }
// Create Device // Create Device
@ -140,12 +162,6 @@ void RendererVK::initGraphicsContext(SDL_Window* window) {
// Initialize device-specific function pointers // Initialize device-specific function pointers
VULKAN_HPP_DEFAULT_DISPATCHER.init(device.get()); VULKAN_HPP_DEFAULT_DISPATCHER.init(device.get());
if (VkSurfaceKHR newSurface; SDL_Vulkan_CreateSurface(window, instance.get(), &newSurface)) {
surface.reset(newSurface);
} else {
Helpers::warn("Error creating Vulkan surface");
}
} }
void RendererVK::clearBuffer(u32 startAddress, u32 endAddress, u32 value, u32 control) {} void RendererVK::clearBuffer(u32 startAddress, u32 endAddress, u32 value, u32 control) {}