From 817e7b1fdb15747459be110140cca7314f5a4b0c Mon Sep 17 00:00:00 2001 From: Xphalnos <164882787+Xphalnos@users.noreply.github.com> Date: Sun, 2 Mar 2025 12:21:20 +0100 Subject: [PATCH] Reduce Warnings on Windows + Don't Upload Unnecessary Qt Files --- .github/workflows/Qt_Build.yml | 8 ++++---- CMakeLists.txt | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/Qt_Build.yml b/.github/workflows/Qt_Build.yml index e36f2023..20e31f33 100644 --- a/.github/workflows/Qt_Build.yml +++ b/.github/workflows/Qt_Build.yml @@ -20,7 +20,7 @@ jobs: run: git submodule update --init --recursive - name: Setup Qt - uses: jurplel/install-qt-action@v3 + uses: jurplel/install-qt-action@v4 with: arch: win64_msvc2019_64 version: 6.2.0 @@ -42,7 +42,7 @@ jobs: run: | mkdir upload move build/Release/Alber.exe upload - windeployqt --dir upload upload/Alber.exe + windeployqt --no-compiler-runtime --no-system-d3d-compiler --dir upload upload/Alber.exe - name: Upload executable uses: actions/upload-artifact@v4 @@ -74,8 +74,8 @@ jobs: run: | brew install dylibbundler imagemagick - - name: Install Qt - uses: jurplel/install-qt-action@v3 + - name: Setup Qt + uses: jurplel/install-qt-action@v4 with: aqtversion: '==3.1.*' version: '6.8.1' diff --git a/CMakeLists.txt b/CMakeLists.txt index 92bff3d2..7c56a14c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -151,6 +151,7 @@ include_directories(third_party/mio/single_include) add_compile_definitions(NOMINMAX) # Make windows.h not define min/max macros because third-party deps don't like it add_compile_definitions(WIN32_LEAN_AND_MEAN) # Make windows.h not include literally everything +add_compile_definitions(_CRT_SECURE_NO_WARNINGS) add_compile_definitions(SDL_MAIN_HANDLED) if(ENABLE_WAYLAND)