Diamond75/Panda3DS
1
0
Fork 0
mirror of https://github.com/wheremyfoodat/Panda3DS.git synced 2025-05-07 04:34:48 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add Helpers:{getBits,getBit}

Browse source 
`constexpr` functions for extractint bitfields that lends itself a bit
better to emitting instructions like `bextr` on x86 or `ubfx` on arm64.
And may subjectively make things a bit more readable.
"Extract `5` bits" rather than `& 0x1F`.
This commit is contained in:
Wunkolo 2023-06-09 21:28:46 -07:00
parent c7e3343974
commit 2c94d0d683
9 changed files with 180 additions and 147 deletions
src/core/loader
lz77.cpp

4
src/core/loader/lz77.cpp
View file

@ -24,7 +24,7 @@ bool CartLZ77::decompress(std::vector<u8>& output, const std::vector<u8>& input)
std::memcpy(&bufferTopAndBottom, footer, sizeof(u32));
u32 out = sizeDecompressed; // TODO: Is this meant to be u32 or s32?
u32 index = sizeCompressed - ((bufferTopAndBottom >> 24) & 0xff);
u32 index = sizeCompressed - (Helpers::getBits<24, 8>(bufferTopAndBottom));
u32 stopIndex = sizeCompressed - (bufferTopAndBottom & 0xffffff);
// Set all of the decompressed buffer to 0 and copy the compressed buffer to the start of it
@ -49,7 +49,7 @@ bool CartLZ77::decompress(std::vector<u8>& output, const std::vector<u8>& input)
index -= 2;
u32 segmentOffset = compressed[index] | (compressed[index + 1] << 8);
u32 segment_size = ((segmentOffset >> 12) & 15) + 3;
u32 segment_size = (Helpers::getBits<12, 4>(segmentOffset)) + 3;
segmentOffset &= 0x0FFF;
segmentOffset += 2;