Proper stack management

src/core/loader/elf.cpp

@@ -14,6 +14,13 @@ std::optional<u32> Memory::loadELF(std::ifstream& file) {
 		return std::nullopt;
 	}
 
+    // Allocate stack space. For ELFs we use the default stack size, which is 16KB
+	if (!allocateMainThreadStack(VirtualAddrs::DefaultStackSize)) {
+		// Should be unreachable
+		printf("Failed to allocate stack space for ELF file\n");
+		return std::nullopt;
+	}
+
     auto segNum = reader.segments.size();
     printf("Number of segments: %d\n", segNum);
     printf(" #  Perms       Vaddr           File Size       Mem Size\n");

src/core/loader/ncsd.cpp

@@ -9,6 +9,27 @@ bool Memory::mapCXI(NCSD& ncsd, NCCH& cxi) {
 	printf("Text address = %08X, size = %08X\n", cxi.text.address, cxi.text.size);
 	printf("Rodata address = %08X, size = %08X\n", cxi.rodata.address, cxi.rodata.size);
 	printf("Data address = %08X, size = %08X\n", cxi.data.address, cxi.data.size);
+	printf("Stack size: %08X\n", cxi.stackSize);
+
+	if (!isAligned(cxi.stackSize)) {
+		Helpers::warn("CXI has a suspicious stack size of %08X which is not a multiple of 4KB", cxi.stackSize);
+	}
+
+	// Round up the size of the CXI stack size to a page (4KB) boundary, as the OS can only allocate memory this way
+	u32 stackSize = (cxi.stackSize + pageSize - 1) & -pageSize;
+
+	if (stackSize > 512_KB) {
+		// TODO: Figure out the actual max stack size
+		Helpers::warn("CXI stack size is %08X which seems way too big. Clamping to 512KB", stackSize);
+		stackSize = 512_KB;
+	}
+
+	// Allocate stack
+	if (!allocateMainThreadStack(stackSize)) {
+		// Should be unreachable
+		printf("Failed to allocate stack for CXI partition. Requested stack size: %08X\n", stackSize);
+		return false;
+	}
 
 	// Map code file to memory
 	auto& code = cxi.codeFile;