Diamond75/Panda3DS
1
0
Fork 0
mirror of https://github.com/wheremyfoodat/Panda3DS.git synced 2025-05-18 01:33:58 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

Avoid usage of D24-S8 format

Browse source 
This support is not supported on `radv`. Vulkan mandates D16 only and a
combination of Depth and Depth-Stencil types only.
This commit is contained in:
Wunkolo 2023-08-11 23:07:12 -07:00
parent 27268f86d3
commit 50029e1333
1 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/core/renderer_vk/vk_pica.cpp
View file

@ -14,10 +14,20 @@ namespace Vulkan {
} }
vk::Format depthFormatToVulkan(PICA::DepthFmt depthFormat) { vk::Format depthFormatToVulkan(PICA::DepthFmt depthFormat) {
switch (depthFormat) { switch (depthFormat) {
// VK_FORMAT_D16_UNORM is mandated by the vulkan specification
case PICA::DepthFmt::Depth16: return vk::Format::eD16Unorm; case PICA::DepthFmt::Depth16: return vk::Format::eD16Unorm;
case PICA::DepthFmt::Unknown1: return vk::Format::eUndefined; case PICA::DepthFmt::Unknown1: return vk::Format::eUndefined;
case PICA::DepthFmt::Depth24: return vk::Format::eX8D24UnormPack32; // The GPU may _not_ support these formats natively
case PICA::DepthFmt::Depth24Stencil8: return vk::Format::eD24UnormS8Uint; // Only one of:
// VK_FORMAT_X8_D24_UNORM_PACK32 and VK_FORMAT_D32_SFLOAT
// and one of:
// VK_FORMAT_D24_UNORM_S8_UINT and VK_FORMAT_D32_SFLOAT_S8_UINT
// will be supported
// TODO: Detect this!
// case PICA::DepthFmt::Depth24: return vk::Format::eX8D24UnormPack32;
// case PICA::DepthFmt::Depth24Stencil8: return vk::Format::eD24UnormS8Uint;
case PICA::DepthFmt::Depth24: return vk::Format::eD32Sfloat;
case PICA::DepthFmt::Depth24Stencil8: return vk::Format::eD32SfloatS8Uint;
} }
return vk::Format::eUndefined; return vk::Format::eUndefined;
} }