Address review comments

This commit is contained in:
GPUCode 2023-08-03 16:42:01 +03:00
parent c805504f70
commit 58383ee431
2 changed files with 12 additions and 10 deletions

View file

@ -187,7 +187,7 @@ void GPU::writeInternalReg(u32 index, u32 value, u32 mask) {
} }
break; break;
// Restart immediate mode primitive drawing // Restart immediate mode primitive drawing
case PrimitiveRestart: case PrimitiveRestart:
if (value & 1) { if (value & 1) {
immediateModeAttrIndex = 0; immediateModeAttrIndex = 0;

View file

@ -21,14 +21,16 @@ namespace ServiceCommands {
} }
// Commands written to shared memory and processed by TriggerCmdReqQueue // Commands written to shared memory and processed by TriggerCmdReqQueue
enum class GXCommands : u32 { namespace GXCommands {
TriggerDMARequest = 0, enum : u32 {
ProcessCommandList = 1, TriggerDMARequest = 0,
MemoryFill = 2, ProcessCommandList = 1,
TriggerDisplayTransfer = 3, MemoryFill = 2,
TriggerTextureCopy = 4, TriggerDisplayTransfer = 3,
FlushCacheRegions = 5 TriggerTextureCopy = 4,
}; FlushCacheRegions = 5
};
}
void GPUService::reset() { void GPUService::reset() {
privilegedProcess = 0xFFFFFFFF; // Set the privileged process to an invalid handle privilegedProcess = 0xFFFFFFFF; // Set the privileged process to an invalid handle
@ -293,7 +295,7 @@ void GPUService::processCommandBuffer() {
log("Processing %d GPU commands\n", commandsLeft); log("Processing %d GPU commands\n", commandsLeft);
while (commandsLeft != 0) { while (commandsLeft != 0) {
const GXCommands cmdID = static_cast<GXCommands>(cmd[0] & 0xff); const u32 cmdID = cmd[0] & 0xff;
switch (cmdID) { switch (cmdID) {
case GXCommands::ProcessCommandList: processCommandList(cmd); break; case GXCommands::ProcessCommandList: processCommandList(cmd); break;
case GXCommands::MemoryFill: memoryFill(cmd); break; case GXCommands::MemoryFill: memoryFill(cmd); break;