From 5b8bb12860ade96dbecc030d2f6a2286295fa528 Mon Sep 17 00:00:00 2001 From: wheremyfoodat <44909372+wheremyfoodat@users.noreply.github.com> Date: Sun, 20 Aug 2023 01:52:23 +0300 Subject: [PATCH] Make svcCreateThread panic with invalid IDs --- src/core/kernel/threads.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/core/kernel/threads.cpp b/src/core/kernel/threads.cpp index 68e02d56..96026365 100644 --- a/src/core/kernel/threads.cpp +++ b/src/core/kernel/threads.cpp @@ -389,10 +389,8 @@ void Kernel::createThread() { return; } - if (id < -2 && id > 3) { - Helpers::warn("Invalid processor ID in CreateThread"); - // TODO: This should return an error - id = static_cast(ProcessorID::AppCore); + if (id < -2 || id > 3) { + Helpers::panic("Invalid processor ID in CreateThread"); } regs[0] = Result::Success;