Diamond75/Panda3DS
1
0
Fork 0
mirror of https://github.com/wheremyfoodat/Panda3DS.git synced 2025-04-20 20:49:12 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

[PICA] Why is attribute fetching so hard

Browse source
This commit is contained in:
wheremyfoodat 2022-09-23 00:55:16 +03:00
parent 39bfeda586
commit 8770e6dc41
6 changed files with 44 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/core/PICA/gpu.cpp
View file

@ -13,6 +13,8 @@ GPU::GPU(Memory& mem) : mem(mem) {
for (auto& e : attributeInfo) {
e.offset = 0;
e.size = 0;
e.config1 = 0;
e.config2 = 0;
}
}
@ -41,6 +43,10 @@ void GPU::drawArrays() {
const u32 vertexBase = ((regs[PICAInternalRegs::VertexAttribLoc] >> 1) & 0xfffffff) * 16;
const u32 vertexCount = regs[PICAInternalRegs::VertexCountReg]; // Total # of vertices to transfer
// Stuff the global attribute config registers in one u64 to make attr parsing easier
// TODO: Cache this when the vertex attribute format registers are written to
u64 vertexCfg = u64(regs[PICAInternalRegs::AttribFormatLow]) | (u64(regs[PICAInternalRegs::AttribFormatHigh]) << 32);
if constexpr (!indexed) {
u32 offset = regs[PICAInternalRegs::VertexOffsetReg];
printf("PICA::DrawArrays(vertex count = %d, vertexOffset = %d)\n", vertexCount, offset);
@ -58,14 +64,23 @@ void GPU::drawArrays() {
int attrCount = 0; // Number of attributes we've passed to the shader
for (int attrCount = 0; attrCount < totalAttribCount; attrCount++) {
auto& attr = attributeInfo[attrCount]; // Get information for this attribute
// Check if attribute is fixed or not
if (fixedAttribMask & (1 << attrCount)) { // Fixed attribute
} else { // Non-fixed attribute
auto& attr = attributeInfo[attrCount]; // Get information for this attribute
u64 attrCfg = attr.getConfigFull(); // Get config1 | (config2 << 32)
uint index = (attrCfg >> (attrCount * 4)) & 0xf; // Get index of attribute in vertexCfg
if (index >= 12) Helpers::panic("[PICA] Vertex attribute used as padding");
u32 attribInfo = (vertexCfg >> (index * 4)) & 0xf;
u32 attribType = attribInfo & 0x3;
u32 attribSize = (attribInfo >> 2) + 1;
// Address to fetch the attribute from
u32 attrAddress = vertexBase + attr.offset + (vertexIndex * attr.size);
printf("Attribute %d, type: %d, size: %d\n", attrCount, attribType, attribSize);
}
}
}

7
src/core/PICA/regs.cpp
View file

@ -74,8 +74,11 @@ void GPU::writeInternalReg(u32 index, u32 value, u32 mask) {
switch (reg) {
case 0: attr.offset = value & 0xfffffff; break; // Attribute offset
case 1: break; // We don't handle this yet
case 2: // We don't handle most of this yet
case 1:
attr.config1 = value;
break;
case 2:
attr.config2 = value;
attr.size = (value >> 16) & 0xff;
break;
}