From b1b430f92b2cafb5ed9228ed1a2e0697f8894682 Mon Sep 17 00:00:00 2001 From: wheremyfoodat <44909372+wheremyfoodat@users.noreply.github.com> Date: Thu, 17 Aug 2023 15:14:05 +0300 Subject: [PATCH 1/2] Add forgotten fclose calls --- src/core/fs/archive_ext_save_data.cpp | 1 + src/core/fs/archive_save_data.cpp | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/core/fs/archive_ext_save_data.cpp b/src/core/fs/archive_ext_save_data.cpp index ca03b326..a39259c3 100644 --- a/src/core/fs/archive_ext_save_data.cpp +++ b/src/core/fs/archive_ext_save_data.cpp @@ -20,6 +20,7 @@ HorizonResult ExtSaveDataArchive::createFile(const FSPath& path, u64 size) { // Create a file of size "size" by creating an empty one, seeking to size - 1 and just writing a 0 there IOFile file(p.string().c_str(), "wb"); if (file.seek(size - 1, SEEK_SET) && file.writeBytes("", 1).second == 1) { + file.close(); return Result::Success; } diff --git a/src/core/fs/archive_save_data.cpp b/src/core/fs/archive_save_data.cpp index 1dcc1db8..af8841c9 100644 --- a/src/core/fs/archive_save_data.cpp +++ b/src/core/fs/archive_save_data.cpp @@ -19,11 +19,13 @@ HorizonResult SaveDataArchive::createFile(const FSPath& path, u64 size) { // If the size is 0, leave the file empty and return success if (size == 0) { + file.close(); return Result::Success; } // If it is not empty, seek to size - 1 and write a 0 to create a file of size "size" else if (file.seek(size - 1, SEEK_SET) && file.writeBytes("", 1).second == 1) { + file.close(); return Result::Success; } From 293c14de7ddc1cde73f406b0d966dc4c9452d5f8 Mon Sep 17 00:00:00 2001 From: wheremyfoodat <44909372+wheremyfoodat@users.noreply.github.com> Date: Thu, 17 Aug 2023 15:30:34 +0300 Subject: [PATCH 2/2] More fclose cause why not --- src/core/fs/archive_ext_save_data.cpp | 1 + src/core/fs/archive_save_data.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/src/core/fs/archive_ext_save_data.cpp b/src/core/fs/archive_ext_save_data.cpp index a39259c3..c07f3353 100644 --- a/src/core/fs/archive_ext_save_data.cpp +++ b/src/core/fs/archive_ext_save_data.cpp @@ -24,6 +24,7 @@ HorizonResult ExtSaveDataArchive::createFile(const FSPath& path, u64 size) { return Result::Success; } + file.close(); return Result::FS::FileTooLarge; } diff --git a/src/core/fs/archive_save_data.cpp b/src/core/fs/archive_save_data.cpp index af8841c9..107aefde 100644 --- a/src/core/fs/archive_save_data.cpp +++ b/src/core/fs/archive_save_data.cpp @@ -29,6 +29,7 @@ HorizonResult SaveDataArchive::createFile(const FSPath& path, u64 size) { return Result::Success; } + file.close(); return Result::FS::FileTooLarge; }