From 463c47af4f7621e21d6e31fe0de402bcacbca4f2 Mon Sep 17 00:00:00 2001 From: xkevio Date: Tue, 6 Jun 2023 01:57:07 +0200 Subject: [PATCH 1/4] Fix GCC build error by correctly including `` header This is needed to not rely on implementation defined behavior regarding transitive header includes, here for std::integer_sequence. --- include/helpers.hpp | 1 + 1 file changed, 1 insertion(+) diff --git a/include/helpers.hpp b/include/helpers.hpp index 8164dae4..7cd64344 100644 --- a/include/helpers.hpp +++ b/include/helpers.hpp @@ -3,6 +3,7 @@ #include #include #include +#include #include #include "termcolor.hpp" From dee81bc62d50d63c7c0bf77ca7690d1f4a6df5ab Mon Sep 17 00:00:00 2001 From: xkevio Date: Tue, 6 Jun 2023 02:11:07 +0200 Subject: [PATCH 2/4] Add `` header for `std::integral_constant` --- include/helpers.hpp | 1 + 1 file changed, 1 insertion(+) diff --git a/include/helpers.hpp b/include/helpers.hpp index 7cd64344..ee1a1dac 100644 --- a/include/helpers.hpp +++ b/include/helpers.hpp @@ -3,6 +3,7 @@ #include #include #include +#include #include #include #include "termcolor.hpp" From e0af6969c67841e205507bb63bd7fd667403cc13 Mon Sep 17 00:00:00 2001 From: Wunkolo Date: Fri, 9 Jun 2023 20:23:14 -0700 Subject: [PATCH 3/4] Fix cmake out-of-source build instructions These directions are incorrectly using `cmake .` when it should be `cmake ..`. --- readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/readme.md b/readme.md index a3b2b37a..8631d18f 100644 --- a/readme.md +++ b/readme.md @@ -31,7 +31,7 @@ All you need is CMake and a generator of your choice (Make, Visual Studio, Ninja git clone https://github.com/wheremyfoodat/Panda3DS --recursive cd Panda3DS && mkdir build && cd build -cmake . -DCMAKE_BUILD_TYPE=Release # Set up compilers etc here if you'd like +cmake .. -DCMAKE_BUILD_TYPE=Release # Set up compilers etc here if you'd like ``` From 2edc9d5fb79930121ccd6f5c7b7ba92e7d0ba4f9 Mon Sep 17 00:00:00 2001 From: Wunkolo Date: Fri, 9 Jun 2023 20:31:25 -0700 Subject: [PATCH 4/4] Remove `#pragma once` from source file --- src/core/loader/lz77.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/core/loader/lz77.cpp b/src/core/loader/lz77.cpp index 85bb96d2..2acc9eb5 100644 --- a/src/core/loader/lz77.cpp +++ b/src/core/loader/lz77.cpp @@ -1,4 +1,3 @@ -#pragma once #include #include #include "loader/lz77.hpp"