From f095e6af0bd96ebfd540dd438bfdccc409dd79c5 Mon Sep 17 00:00:00 2001 From: wheremyfoodat <44909372+wheremyfoodat@users.noreply.github.com> Date: Fri, 26 Jul 2024 14:44:11 +0300 Subject: [PATCH] Shadergen: Move comments outside of emitted source code --- src/core/PICA/shader_gen_glsl.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/PICA/shader_gen_glsl.cpp b/src/core/PICA/shader_gen_glsl.cpp index 41b33d88..60887d56 100644 --- a/src/core/PICA/shader_gen_glsl.cpp +++ b/src/core/PICA/shader_gen_glsl.cpp @@ -4,6 +4,8 @@ using namespace PICA; using namespace PICA::ShaderGen; +// Note: We upload global ambient and fog colour as u32 and decode on the GPU +// This shouldn't matter much for GPU performance, especially fog since it's relatively rare static constexpr const char* uniformDefinition = R"( struct LightSource { vec3 specular0; @@ -24,8 +26,6 @@ static constexpr const char* uniformDefinition = R"( vec4 constantColors[6]; vec4 tevBufferColor; vec4 clipCoords; - - // Note: We upload this as a u32 and decode on GPU uint globalAmbientLight; uint inFogColor; LightSource lightSources[8];